fix: pass variables into a function #16291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
commented
Dec 19, 2019
| const config = transform( | ||
| TELEGRAF_OUTPUT, | ||
| Object.assign({}, OUTPUT_DEFAULTS, {}) | ||
| Object.assign({}, OUTPUT_DEFAULTS, { | ||
| server, |
There was a problem hiding this comment.
this is the actual magic
| const config = transform( | ||
| TELEGRAF_OUTPUT, | ||
| Object.assign({}, OUTPUT_DEFAULTS, {}) | ||
| Object.assign({}, OUTPUT_DEFAULTS, { |
There was a problem hiding this comment.
interesting that this isn't being destructured, might be worth considering when thinking about patterns @ebb-tide.
also, it looks like there's an extra space in indentation below, i think you'll need to run prettier:fix
There was a problem hiding this comment.
i dont understand
hoorayimhelping
approved these changes
Dec 19, 2019
ghost
requested review from
asalem1 and
TCL735
and removed request for
a team
TCL735
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16290
just looks like the template function wasn't being passed variables. also took time to normalize some internal state while rummaging around in there.