Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add trace response headers #16158

Merged
merged 1 commit into from
Dec 11, 2019
Merged

feat(query): add trace response headers #16158

merged 1 commit into from
Dec 11, 2019

Conversation

gavincabbage
Copy link
Contributor

@gavincabbage gavincabbage commented Dec 6, 2019 •
edited
Loading

Adds Trace-Id response header to query endpoint.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)

@gavincabbage gavincabbage requested review from a team as code owners December 6, 2019 19:04
kelwang
kelwang reviewed Dec 6, 2019
View reviewed changes
http/query_handler.go Outdated Show resolved Hide resolved
kelwang
kelwang reviewed Dec 6, 2019
View reviewed changes
logger/fields.go Outdated Show resolved Hide resolved
@gavincabbage gavincabbage force-pushed the feat/trace-id-response-header branch from bd4ca68 to 13886f5 Compare December 6, 2019 19:15
@gavincabbage
Copy link
Contributor Author

apologies for leaving those debugs in @kelwang, ive removed them both

AlirieGray
AlirieGray approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@AlirieGray AlirieGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gavincabbage gavincabbage requested a review from kelwang December 10, 2019 17:31
aanthony1243
aanthony1243 reviewed Dec 10, 2019
View reviewed changes
http/query_handler.go Outdated Show resolved Hide resolved
@gavincabbage gavincabbage force-pushed the feat/trace-id-response-header branch from 13886f5 to fcd3d8c Compare December 10, 2019 17:38
@gavincabbage gavincabbage force-pushed the feat/trace-id-response-header branch 2 times, most recently from 01d5258 to d7dddb6 Compare December 10, 2019 19:29
@gavincabbage gavincabbage force-pushed the feat/trace-id-response-header branch from d7dddb6 to c0de094 Compare December 11, 2019 13:30
@gavincabbage gavincabbage merged commit 43ff4ab into master Dec 11, 2019
@gavincabbage gavincabbage deleted the feat/trace-id-response-header branch December 11, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanthony1243 aanthony1243 aanthony1243 approved these changes

@AlirieGray AlirieGray AlirieGray approved these changes

@kelwang kelwang kelwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavincabbage @kelwang @AlirieGray @aanthony1243