fix(cli): add organization back to bucket response #15947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kelwang
suggested changes
Nov 18, 2019
|
@kelwang organization IDs do not show for buckets in the CLI currently because the keys specified in the tab writer body don't match those in the tab writer header. This fixes that. Specifically, one of them is "OrgID" and the other is "OrganizationID". |
|
Ah, okay. Could you change OrganizationID to OrgID, seems most of our code base is using OrgID instead. |
|
@kelwang we use organizationID in all other places in our CLI, so this is consistent with that. I'd rather merge this and have that be a separate issue if we want it. |
kelwang
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15828
This fixes a mismatch between tabwriter keys introduced by 9d44ac3.
It's probably worth considering adding org names back in the response. Expecting users to work with orgIDs for everything feels like bad UX when it's really an internal implementation detail.