Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kv): unique variable names #15695

Merged
merged 3 commits into from
Nov 4, 2019
Merged

feat(kv): unique variable names #15695

merged 3 commits into from
Nov 4, 2019

Conversation

dearyhud
Copy link
Contributor

@dearyhud dearyhud commented Oct 31, 2019 •
edited
Loading

  • adds system bucket for creatingn an index of unique variabel names
  • adds tests

Closes #

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@dearyhud dearyhud marked this pull request as ready for review November 1, 2019 17:32
@dearyhud dearyhud force-pushed the feat/kv-unique-variables branch from 148175f to 92d9f6c Compare November 1, 2019 17:42
@dearyhud dearyhud requested a review from a team November 1, 2019 18:21
@dearyhud dearyhud force-pushed the feat/kv-unique-variables branch from a4da264 to a8c8ddf Compare November 4, 2019 17:05
Deary Hudson and others added 2 commits November 4, 2019 11:56
@dearyhud
feat(kv): unique variable names
1a2d78f 
- adds system bucket for creatingn an index of unique variabel names
- adds tests
@dearyhud
fix: tests should pass now
4cb86e6 
deleted tests for dead code

removed a test runner for the variable service from http - doesn't really make sense to run it from there
@dearyhud dearyhud force-pushed the feat/kv-unique-variables branch from 82b97ae to 9a02bb5 Compare November 4, 2019 18:05
@dearyhud dearyhud force-pushed the feat/kv-unique-variables branch from 9a02bb5 to 476a10c Compare November 4, 2019 20:02
@dearyhud dearyhud merged commit 81965f0 into master Nov 4, 2019
@dearyhud dearyhud deleted the feat/kv-unique-variables branch November 4, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelwang kelwang kelwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dearyhud @kelwang