fix(onboarding): remove fancy scrollbar that hides content #14931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goller
force-pushed
the
fix/onboarding-scrollbar-removal
branch
from
f1d5c2a to
b5ca306
Compare
|
Can I see a screenshot of how this looks? |
e2e tests are failing because the fancyscroll bar component hides the admin step during certain points in onboarding. We were able to reproduce when the form in the admin step had been marked as valid. The use of the scrollbar in the setting seemed unneeded as it could be rendered in a quite small window. Therefore, we removed the scrollbar altogether for now. Co-authored-by: Christopher Henn <[email protected]>
goller
force-pushed
the
fix/onboarding-scrollbar-removal
branch
from
b5ca306 to
ed3ec33
Compare
|
@alexpaxton There were no visual changes, since the onboarding step was wrapped in a |
|
|
alexpaxton
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e tests are failing because the fancyscroll bar component hides
the admin step during certain points in onboarding.
We were able to reproduce when the form in the admin step had been
marked as valid.
The use of the scrollbar in the setting seemed unneeded as it could
be rendered in a quite small window.
Therefore, we removed the scrollbar altogether for now.
Co-authored-by: Christopher Henn [email protected]