Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clears tsm files when replace fails #14246

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Clears tsm files when replace fails #14246

merged 3 commits into from
Aug 7, 2019

Conversation

maxunt
Copy link
Contributor

@maxunt maxunt commented Jul 2, 2019

Closes #14058

When compaction fails, instead of simply printing error message, clear tmp.tsm files so we can try again

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

e-dard
e-dard suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the log level. Aside from that, this is looking great 👍

tsdb/tsm1/engine.go Outdated Show resolved Hide resolved
@jacobmarble jacobmarble requested a review from e-dard July 15, 2019 17:19
e-dard
e-dard approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @stuartcarnie can you confirm?

@maxunt
Copy link
Contributor Author

maxunt commented Aug 7, 2019

alchemy please merge

@maxunt maxunt merged commit 62d1474 into master Aug 7, 2019
@mark-rushakoff mark-rushakoff deleted the mu-tsm-clean-14058 branch April 16, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmarble jacobmarble jacobmarble approved these changes

@e-dard e-dard e-dard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporary TSM files not cleaned up when compaction rename fails
3 participants
@maxunt @e-dard @jacobmarble