Drop all unsupported Prometheus values written to the remote write endpoint #12813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the Prometheus remote write endpoint to drop unsupported Prometheus values, rather than reject the entire batch. InfluxDB does not support NaN, -Inf or +Inf, but Prometheus does. The remote write endpoint will now drop these and write valid values in the provided batch. If the user enabled write trace logging (`[http] write-tracing = true`) then summaries of any dropped values within a batch will be logged. If a batch of values contains any values that are subsequently dropped, the returned status code will be `204`.
jacobmarble
approved these changes
Mar 25, 2019
This was referenced Apr 1, 2019
|
For 1.7.6 release, appended the following to the Prometheus (https://docs.influxdata.com/influxdb/v1.7/supported_protocols/prometheus/#how-prometheus-metrics-are-parsed-in-influxdb):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10490.
This PR extends the Prometheus remote write endpoint to drop
unsupported Prometheus values, rather than reject the entire batch.
InfluxDB does not support
NaN,-Infor+Inf, but Prometheus does. Theremote write endpoint will now drop these and write valid values in the
provided batch.
If the user enabled write trace logging (
[http] write-tracing = true)then summaries of any dropped values within a batch will be logged.
If a batch of values contains any values that are subsequently dropped,
the returned status code will be
204./cc @stevebang we should edit https://docs.influxdata.com/influxdb/v1.7/supported_protocols/prometheus/#how-prometheus-metrics-are-parsed-in-influxdb so that it explains what happens if
NaN,Infor-Infare written to InfluxDB via the Prometheus remote write endpoint.