Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bucket selection to first card in Query Builder #12782

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 20, 2019

Closes #11012

Screen Shot 2019-03-20 at 10 14 45 AM

Also made the raw data toggle into a component that doesn't get any props from its parent so it will be easier to experiment with placement.

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)


type Props = StateProps & DispatchProps

class TimeMachineQueries extends PureComponent<Props> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TimeMachineQueries extends PureComponent<Props> {
class RawDataToggle extends PureComponent<Props> {

@alexpaxton alexpaxton merged commit b1d8325 into master Mar 20, 2019
@alexpaxton alexpaxton deleted the feat/de-bucket-card branch March 20, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants