Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifications for success/failed when creating/updating/deleting … #12012

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Add notifications for success/failed when creating/updating/deleting … #12012

merged 1 commit into from
Feb 20, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 20, 2019 •
edited
Loading

…scrapers

Closes #11915

Briefly describe your proposed changes:

  • Rebased/mergeable
  • Tests pass

@Palakp41 Palakp41 force-pushed the feat/scraper-notifications branch from 4a4dbec to 1c0b54c Compare February 20, 2019 19:49
chnn
chnn approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Made some suggestions about the notifications copy but 👍

ui/src/shared/copy/v2/notifications.ts Outdated Show resolved Hide resolved
ui/src/shared/copy/v2/notifications.ts Outdated Show resolved Hide resolved
ui/src/shared/copy/v2/notifications.ts Outdated Show resolved Hide resolved
ui/src/shared/copy/v2/notifications.ts Outdated Show resolved Hide resolved
@Palakp41 Palakp41 force-pushed the feat/scraper-notifications branch 2 times, most recently from b141bbd to 3f83665 Compare February 20, 2019 21:37
@Palakp41 Palakp41 force-pushed the feat/scraper-notifications branch from 3f83665 to fb7a3aa Compare February 20, 2019 22:13
@Palakp41 Palakp41 merged commit 38e06c0 into master Feb 20, 2019
@mark-rushakoff mark-rushakoff deleted the feat/scraper-notifications branch February 22, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chnn chnn chnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Palakp41 @chnn