Add ability to update a variable #12011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
feat(variables)/edit-variable
branch
2 times, most recently
from
8410b82 to
4050192
Compare
ischolten
approved these changes
Feb 20, 2019
| super(props) | ||
|
|
||
| const {variable} = this.props | ||
| const script = _.get(variable, 'arguments.values.query') |
There was a problem hiding this comment.
does there need to be a default in this get? like ""?
| <Button | ||
| text="Submit" | ||
| type={ButtonType.Submit} | ||
| onClick={this.handleSubmit} |
There was a problem hiding this comment.
Forms have an onSubmit prop. Since this Button is already type submit, you could remove this.handleSubmit to the onSubmit prop on the form and then get default browser behavior here
| return !!variable.name && !!script | ||
| } | ||
|
|
||
| private handleSubmit = (e): void => { |
There was a problem hiding this comment.
could you type annotate e?
| } | ||
|
|
||
| private handleCloseOverlay = () => { | ||
| this.setState({variableOverlayState: OverlayState.Closed}) |
There was a problem hiding this comment.
should this also reset variableID to null?
| variable.id, | ||
| variable | ||
| ) | ||
| notify(updateVariableSuccess(updatedVariable.name)) |
|
|
||
| interface Props { | ||
| variable: Variable | ||
| onDeleteVariable: (variable: Variable) => void | ||
| onUpdateVariable: (variable: Partial<Variable>) => void | ||
| onEditVariable: (variable: Variable) => void |
There was a problem hiding this comment.
perhaps there is a better name distinction between these two props? both of those names seem like they would do the same thing.
AlirieGray
force-pushed
the
feat(variables)/edit-variable
branch
2 times, most recently
from
aa99185 to
35e7d42
Compare
AlirieGray
force-pushed
the
feat(variables)/edit-variable
branch
from
35e7d42 to
9ccb785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11844
This PR adds the ability to edit a variable's name and query from the Variables tab of the orgs page. It also includes notifications for when an update succeeds or fails.