Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add label from resource labels editor #11973

Merged
merged 6 commits into from
Feb 21, 2019
Merged

fix(ui): add label from resource labels editor #11973

merged 6 commits into from
Feb 21, 2019

Conversation

OfTheDelmer
Copy link
Contributor

@OfTheDelmer OfTheDelmer commented Feb 19, 2019

Closes #11624

Briefly describe your proposed changes:
Add resource label creation form when label is not present. Tune label filtering to not aggressively match labels not in the list to more easily enable user to create a new label. Add a random color button instead of a color dropdown which does not work well in the label list dropdown.

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)
    kapture 2019-02-21 at 7 29 57

Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff.

I left one small comment. I also think that the top of the create label form could using some padding within the dropdown menu.

ui/src/configuration/components/RandomLabelColor.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you update the screenshot to reflect the design changes?

@mavarius
Copy link
Contributor

Closes #11978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants