Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some clean up on feature flag component #11957

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Some clean up on feature flag component #11957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions ui/src/shared/components/FeatureFlag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
import {SFC} from 'react'
import {PureComponent} from 'react'

interface Props {
name?: string
children?: any
}

const FeatureFlag: SFC<Props> = props => {
if (process.env.NODE_ENV === 'development') {
return props.children
export default class extends PureComponent<Props> {
public render() {
if (this.isHidden) {
return null
}

return this.props.children
}

return null
private get isHidden(): boolean {
return process.env.NODE_ENV !== 'development'
}
}

export default FeatureFlag