Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Editable name to not allow empty string inline edit #11819

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update Editable name to not allow empty string inline edit #11819

merged 1 commit into from
Feb 12, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 12, 2019 •
edited
Loading

Closes #11818

Briefly describe your proposed changes:
Update Editable Name to not allow empty string for name

  • Rebased/mergeable
  • Tests pass

kapture 2019-02-12 at 10 02 13

alexpaxton
alexpaxton approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious

@Palakp41 Palakp41 force-pushed the fix/inline-edit-empty branch from ea15950 to 65aefca Compare February 12, 2019 18:08
ischolten
ischolten approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ischolten ischolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Palakp41 Palakp41 force-pushed the fix/inline-edit-empty branch from 65aefca to e0c977d Compare February 12, 2019 18:15
@Palakp41 Palakp41 force-pushed the fix/inline-edit-empty branch from e0c977d to fa220db Compare February 12, 2019 18:47
@Palakp41 Palakp41 merged commit 43cec2b into master Feb 12, 2019
@Palakp41 Palakp41 deleted the fix/inline-edit-empty branch February 12, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ischolten ischolten ischolten approved these changes

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Palakp41 @alexpaxton @ischolten