Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show checked on multidropdown #11711

Merged
merged 1 commit into from
Feb 6, 2019
Merged

fix(ui): show checked on multidropdown #11711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
1. [11683](https://github.com/influxdata/influxdb/pull/11683): Change the wording for the plugin config form button to Done
1. [11689](https://github.com/influxdata/influxdb/pull/11689): Change the wording for the Collectors configure step button to Create and Verify
1. [11697](https://github.com/influxdata/influxdb/pull/11697): Standardize page loading spinner styles
1. [11711](https://github.com/influxdata/influxdb/pull/11711): Show checkbox on Save As button in data explorer

## v2.0.0-alpha.1 [2019-01-23]

Expand Down
4 changes: 4 additions & 0 deletions ui/src/clockface/components/dropdowns/Dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@
opacity: 1;
transform: translate(-50%,-50%) scale(1,1);
}

.checked &:after {
opacity: 1;
}
}

/* Themes */
Expand Down
4 changes: 3 additions & 1 deletion ui/src/dataExplorer/components/DashboardsDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ class DashboardsDropdown extends PureComponent<Props> {
}

private get dividerItem(): JSX.Element {
return <MultiSelectDropdown.Divider key={0} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default for a new dashboard has id of 0 and key of 0 so this was causing a key collision

return (
<MultiSelectDropdown.Divider id="divider" key="existing-dashboards" />
)
}
}
export default DashboardsDropdown