Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Clockface Spinners #11697

Merged
merged 8 commits into from
Feb 6, 2019
Merged

Improve Clockface Spinners #11697

merged 8 commits into from
Feb 6, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Feb 5, 2019 •
edited
Loading

Closes #11545

  • Create SpinnerContainer component which renders a spinner of your choice and determines whether to render the child or not depending on remoteDataState.
  • Create TechnoSpinner component which resembles the current styles of .page-spinner
  • Replace all instances of .page-spinner and Spinner with a combination of SpinnerContainer + TechnoSpinner
  • Remove obsolete files

Checklist

  • Rebased/mergeable
  • Tests pass

@alexpaxton alexpaxton merged commit cd6fb3c into master Feb 6, 2019
@alexpaxton alexpaxton deleted the clockface/spinners branch February 6, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @mavarius