-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit should default to 10K #61
Comments
+1 Cassandra does the same thing:
|
A followup on this, when I have a serie with > 10k events, and I issue the following query:
I get back 10000. While:
Gives indeed back the correct number of events. I get this has to do with this issue. Although I believe this isn't preferable when using group-like functions, right? |
Hmmm yes, you're probably right. We'll reopen and have the limit go away if you're using an aggregate function. |
I think for the time being we're going to get rid of the default limit. We are thinking about revisiting this issue later to have a database configuration for the maximum number of points a user can retrieve in a query. I'll close this issue with a commit in a little bit. |
This is actually still in the db at https://github.com/influxdb/influxdb/blob/master/src/datastore/leveldb_datastore.go#L773 |
Fixed in 52fad8d |
This commit does two things: 1. It will load or create a license in the object store to be checked for validity. 2. It will validate that said license is not being used past the expiry date and spawn a task to continue validating that said license is valid 3. Disable querying endpoints so long as the license is expired Note that: 1. This does work from local testing, but does not contain tests. This is due to the fact that mocking it is hard to do without a valid JWT token. For testing we will want to create a JWT for when a license is expired or valid in the future. 2. This code will not work when run now unless you have a valid license, create one locally with the license service, or you compile the code with the `no-license` feature flag. Closes #57 Closes #58 Closes #61
Instead of defaulting the start time to now() - 1h, we should be limiting the number of points that are returned to the user, unless they explicitly set LIMIT 0. In which case the limit won't be set.
The text was updated successfully, but these errors were encountered: