Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build issue on Solaris #4787

Closed
fazalmajid opened this issue Nov 13, 2015 · 3 comments
Closed

Build issue on Solaris #4787

fazalmajid opened this issue Nov 13, 2015 · 3 comments
Labels
area/tsm

Comments

@fazalmajid
Copy link

tsdb/engine/tsm1/tsm1.go is using the obsolete syscall.Mmap and Munmap instead of golang.org/x/sys/unix.Mmap like BoltDB.

Compilation fails with:

local64 ~/build/influxdb-0.9.4.2/src/github.com/influxdb/influxdb>go build ./...
# github.com/influxdb/influxdb/tsdb/engine/tsm1
tsdb/engine/tsm1/tsm1.go:1974: undefined: syscall.Mmap
tsdb/engine/tsm1/tsm1.go:2033: undefined: syscall.Munmap

See:
@fazalmajid fazalmajid mentioned this issue Nov 13, 2015
Closed
fazalmajid added a commit to Apsalar/influxdb that referenced this issue Nov 13, 2015
@fazalmajid
more portable solution for Mmap/Munmap influxdata#4787
19d3f5b
This was referenced Dec 7, 2015
Closed
Closed
@pauldix
Copy link
Member

pauldix commented Dec 8, 2015

Can you try to build this against master now? We just removed a bunch of stuff that may have caused this problem.

fazalmajid pushed a commit to Apsalar/influxdb that referenced this issue Dec 8, 2015
fix tsm1 for Solaris influxdata#4787, passes unit tests now
0f889a7
@fazalmajid
Copy link
Author

@pauldix yes, I had to create a Solaris-specific mmap_solaris.go (straight copy-paste job from the BoltDB version), and tsm1 now passes its unit tests. Thanks for the help!.

The pull request is #5027

fazalmajid pushed a commit to Apsalar/influxdb that referenced this issue Dec 8, 2015
ran go fmt on mmap_solaris.go influxdata#4787
bb38621
pauldix added a commit that referenced this issue Dec 8, 2015
@pauldix
Merge pull request #5027 from Apsalar/solaris-tsm1-issue#4787
f7b8321 
fix tsm1 for Solaris #4787, passes unit tests now
@pauldix
Copy link
Member

pauldix commented Dec 8, 2015

merged, will go into the 0.9.6 release

@pauldix pauldix closed this as completed Dec 8, 2015
otoolep pushed a commit that referenced this issue Dec 8, 2015
@otoolep
fix tsm1 for Solaris #4787, passes unit tests now
b81ab04
otoolep pushed a commit that referenced this issue Dec 8, 2015
@otoolep
ran go fmt on mmap_solaris.go #4787
46db93f
@bahamat bahamat mentioned this issue Jun 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tsm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pauldix @fazalmajid @otoolep