Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing a few extra characters as timeseries names? #267

Closed
Dieterbe opened this issue Feb 24, 2014 · 11 comments
Closed

allowing a few extra characters as timeseries names? #267

Dieterbe opened this issue Feb 24, 2014 · 11 comments

Comments

@Dieterbe
Copy link
Contributor

Hi,
I'm currently working on integrating https://github.com/graphite-ng/graphite-ng with influxdb (in fact influxdb will become the main datastore), but that means I need support for "metrics 2.0" (link) basically this means timeseries identifiers like:

service=statsdaemon source_host=10.0.2.8 target_type=rate unit=Metric/s direction=in

note that this identifier contains:

  • dot: inside ip addresses, allowed
  • equals: for key/value pairs, not allowed
  • fwd slash: for unit values, not allowed
  • space: to separate tags, not allowed (this could maybe be changed by another char, but it seems others such as comma aren't allowed either)

would it be possible to allow equals, forward slash and spaces?

@Dieterbe
Copy link
Contributor Author

ping @pauldix I now have a functioning prototype with graphite-ng; and I'm a little blocked. the ability to use these characters would mean i can implement metrics 2.0 on top of influxdb (and graphite-ng) which would be really neat. I believe last time we spoke the conclusion was most of them could easily implemented as long as I escape them in my queries, which would be a reasonable compromise.

@jvshahid
Copy link
Contributor

hey @Dieterbe I don't think spaces will be allowed. otherwise it will make the parser more complicated for no reason. can you change the space with another character (say comma) ?

@Dieterbe
Copy link
Contributor Author

yeah i think i can replace all spaces with commas

@samuraraujo
Copy link

I think would be useful to use other characters in the series name.

In my case, I would like to name my series as a URI, .e.g. name => "http://mysite.org/login"

Then I would store two columns to register click and view events on this series (uri).

Another possibility would be to allow to associate metadata to the series itself. Currently, we can only give a name to the series. What about associate an json object to the series? In this way, we could give a human readable name to the series, or add any other useful information to it.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Apr 9, 2014

so can we add support for series names containing equals and forward slash? this would help me with https://github.com/vimeo/graphite-influxdb (this sounds unrelated, but due to various circumstances that's how it is for now)

then comma would help with my metrics 2.0 & graphite-ng work
and apparently, after that colon is all that's needed to help out @samuraraujo

@pauldix
Copy link
Member

pauldix commented Apr 9, 2014

I think we can do this, but forward slash is tricky. I don't think we'll be
able to have series names that begin with a forward slash. Would that be ok?

On Wed, Apr 9, 2014 at 9:00 AM, Dieter Plaetinck
[email protected]:

so can we add support for series names containing equals and forward
slash? this would help me with https://github.com/vimeo/graphite-influxdb(this sounds unrelated, but due to various circumstances that's how it is
for now)

then comma would help with my metrics 2.0 & graphite-ng work
and apparently, after that colon is all that's needed to help out
@samuraraujo https://github.com/samuraraujo

Reply to this email directly or view it on GitHubhttps://github.com//issues/267#issuecomment-39960570
.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Apr 9, 2014

yep, fair enough for me, and also seems fine for @samuraraujo 's case

@daledude
Copy link

Can you add colon to the list?

select * from servers.logserver2.interrupts.IO-APIC-fasteoi.ehci_hcd:usb1-uhci_hcd:usb2-uhci_hcd:usb4.21.CPU6 limit 1

returns

Exception: 400: syntax error, unexpected INTO_NAME, expecting TABLE_NAME or SIMPLE_NAME or REGEX_STRING or INSENSITIVE_REGEX_STRING

@pauldix
Copy link
Member

pauldix commented Apr 22, 2014

#463 takes care of this. You can now use any character you want in a series name. If you happen to use a character other than a-zA-Z0-9.-_ then you'll have to wrap the name in quotes on your select statement. Like this:

select * from "some series ; 23 @#)" where time > now() - 1h

@pauldix
Copy link
Member

pauldix commented Apr 22, 2014

Well, you'l be able to do that once we release 0.5.10, which should be later today.

@Dieterbe
Copy link
Contributor Author

awesome, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants