Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misquoted tag value in SHOW TAG KEYS query can cause OOM [port to 1.9] #22756

Closed
davidby-influx opened this issue Oct 25, 2021 · 0 comments · Fixed by #22781
Closed

Misquoted tag value in SHOW TAG KEYS query can cause OOM [port to 1.9] #22756

davidby-influx opened this issue Oct 25, 2021 · 0 comments · Fixed by #22781
Assignees
@davidby-influx
Labels
1.x area/meta queries kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

Port #22755 to 1.9 branch
@davidby-influx davidby-influx self-assigned this Oct 25, 2021
@davidby-influx davidby-influx mentioned this issue Oct 27, 2021
Merged
3 tasks
davidby-influx added a commit that referenced this issue Oct 27, 2021
@davidby-influx
fix: detect misquoted tag values and return an error (#22754) (#22781)
2b10745 
SHOW TAG KEYS FROM "foo" where bar="misquoted" is
erroneous, because the tag value must be enclosed
in single, not double, quotes. Although this
correctly returns no tag keys, it is very
inefficient and has cause out-of-memory failures
at a customer. This fix short-circuits the query.

closes #22755

(cherry picked from commit af9e89a)

closes #22756
@davidby-influx davidby-influx linked a pull request Oct 27, 2021 that will close this issue
fix: detect misquoted tag values and return an error (#22754) #22781
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/meta queries kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: detect misquoted tag values and return an error (#22754) influxdata/influxdb
1 participant
@davidby-influx