Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewriting fields.idx is a bottleneck with many new fields and measurements [Port to master] #21598

Closed
davidby-influx opened this issue Jun 3, 2021 · 0 comments · Fixed by #21610
Closed

Rewriting fields.idx is a bottleneck with many new fields and measurements [Port to master] #21598

davidby-influx opened this issue Jun 3, 2021 · 0 comments · Fixed by #21610
Assignees
@davidby-influx
Labels
area/performance area/writes area/2.x OSS 2.0 related issues and PRs kind/enhancement team/edge

Comments

@davidby-influx
Copy link
Contributor

#21577 port to master branch for 2.X versions
@davidby-influx davidby-influx self-assigned this Jun 3, 2021
@davidby-influx davidby-influx changed the title Rewriting fields.idx is a bottleneck with many new fields and measurements Rewriting fields.idx is a bottleneck with many new fields and measurements [Port to master] Jun 4, 2021
@davidby-influx davidby-influx mentioned this issue Jun 4, 2021
Merged
4 tasks
davidby-influx added a commit that referenced this issue Jun 4, 2021
@davidby-influx
fix: avoid rewriting fields.idx unnecessarily (#21592) (#21610)
d10a727 
Under heavy write load creating new fields and measurements
the rewrite of the fields.idx file is a bottleneck. This
enhancement combines multiple writes into a single one and
shares any error return value with all of the combined
invocations. MeasurementFieldSet and the new
MeasurementFieldSetWriter must both now be explicitly
closed.

Closes #21577

(cherry picked from commit f64be28)

Closes #21598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
area/performance area/writes area/2.x OSS 2.0 related issues and PRs kind/enhancement team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid rewriting fields.idx unnecessarily (#21592) influxdata/influxdb
1 participant
@davidby-influx