Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewriting fields.idx is a bottleneck with many new fields and measurements [port to 1.9 branch] #21597

Closed
davidby-influx opened this issue Jun 3, 2021 · 2 comments · Fixed by #21609
Closed

Rewriting fields.idx is a bottleneck with many new fields and measurements [port to 1.9 branch] #21597

davidby-influx opened this issue Jun 3, 2021 · 2 comments · Fixed by #21609
Assignees
@davidby-influx
Labels
1.x area/performance area/writes kind/enhancement team/edge

Comments

@davidby-influx
Copy link
Contributor

#21577 port to 1.9 branch for 1.9.2
@davidby-influx davidby-influx self-assigned this Jun 3, 2021
@davidby-influx davidby-influx mentioned this issue Jun 4, 2021
Merged
4 tasks
@davidby-influx davidby-influx linked a pull request Jun 4, 2021 that will close this issue
fix: avoid rewriting fields.idx unnecessarily (#21592) [Port to 1.9] #21609
Merged
4 tasks
davidby-influx added a commit that referenced this issue Jun 4, 2021
@davidby-influx
fix: avoid rewriting fields.idx unnecessarily (#21592) [Port to 1.9] (#…
c8e8025 
…21609)

Under heavy write load creating new fields and measurements
the rewrite of the fields.idx file is a bottleneck. This
enhancement combines multiple writes into a single one and
shares any error return value with all of the combined
invocations. MeasurementFieldSet and the new
MeasurementFieldSetWriter must both now be explicitly
closed.

Closes #21577

(cherry picked from commit f64be28)

Closes #21597
@lesam
Copy link
Contributor

lesam commented Jun 8, 2021

Reopening as I have reverted from 1.9 since it should be in 1.9.3, not 1.9.2

@lesam lesam reopened this Jun 8, 2021
@lesam
Copy link
Contributor

lesam commented Jun 8, 2021

See https://github.com/influxdata/influxdb/compare/master...lesam:1.9-reset?expand=1

lesam pushed a commit to lesam/influxdb that referenced this issue Jun 15, 2021
@davidby-influx @lesam
fix: avoid rewriting fields.idx unnecessarily (influxdata#21592) [Por…
f6286f0 
…t to 1.9] (influxdata#21609)

Under heavy write load creating new fields and measurements
the rewrite of the fields.idx file is a bottleneck. This
enhancement combines multiple writes into a single one and
shares any error return value with all of the combined
invocations. MeasurementFieldSet and the new
MeasurementFieldSetWriter must both now be explicitly
closed.

Closes influxdata#21577

(cherry picked from commit f64be28)

Closes influxdata#21597
@lesam lesam mentioned this issue Jun 15, 2021
Merged
4 tasks
lesam added a commit that referenced this issue Jun 15, 2021
@lesam @davidby-influx
fix: avoid rewriting fields.idx unnecessarily (#21692)
1661b6f 
* fix: avoid rewriting fields.idx unnecessarily (#21592) [Port to 1.9] (#21609)

Under heavy write load creating new fields and measurements
the rewrite of the fields.idx file is a bottleneck. This
enhancement combines multiple writes into a single one and
shares any error return value with all of the combined
invocations. MeasurementFieldSet and the new
MeasurementFieldSetWriter must both now be explicitly
closed.

Closes #21577

(cherry picked from commit f64be28)

Closes #21597

* chore: minor refactor suggested by go lint (#21614) (#21616)

(cherry picked from commit 7d10228)
(cherry picked from commit f820287)

Co-authored-by: davidby-influx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/performance area/writes kind/enhancement team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid rewriting fields.idx unnecessarily (#21592) [Port to 1.9] influxdata/influxdb
2 participants
@lesam @davidby-influx