Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GROUP BY query with offset crossing DST change fails [Backport to 1.8] #20252

Closed
davidby-influx opened this issue Dec 4, 2020 · 0 comments · Fixed by #20277
Closed

GROUP BY query with offset crossing DST change fails [Backport to 1.8] #20252

davidby-influx opened this issue Dec 4, 2020 · 0 comments · Fixed by #20277
Assignees
@davidby-influx
Labels
area/queries kind/bug needs-backport/1.8 team/edge

Comments

@davidby-influx
Copy link
Contributor

Backport #20238 to 1.8
@davidby-influx davidby-influx self-assigned this Dec 4, 2020
@davidby-influx davidby-influx mentioned this issue Dec 7, 2020
Merged
4 tasks
@davidby-influx davidby-influx linked a pull request Dec 7, 2020 that will close this issue
fix(query): Group By queries with offset that crosses a DST boundary can fail #20277
Merged
4 tasks
davidby-influx added a commit that referenced this issue Dec 8, 2020
@davidby-influx
fix(query): Group By queries with offset that crosses a DST boundary …
5a84f77 
…can fail (#20277)

Customer reported that a GROUP BY query with an offset that caused an interval
to cross a daylight savings change inserted an extra output row off by one hour.
This fix ensured that the start time for the interval of a GROUP BY operator is
correctly set before calculating the time zone offset for that date and time.

Add TestGroupByIterator_DST() in query/iterator_test.go
for regression testing of this bug.

Fixes #20238

(cherry picked from commit df39b1e)

Fixes #20252
dgnorton pushed a commit that referenced this issue Feb 3, 2021
@davidby-influx @dgnorton
fix(query): Group By queries with offset that crosses a DST boundary …
981f27f 
…can fail (#20277)

Customer reported that a GROUP BY query with an offset that caused an interval
to cross a daylight savings change inserted an extra output row off by one hour.
This fix ensured that the start time for the interval of a GROUP BY operator is
correctly set before calculating the time zone offset for that date and time.

Add TestGroupByIterator_DST() in query/iterator_test.go
for regression testing of this bug.

Fixes #20238

(cherry picked from commit df39b1e)

Fixes #20252
dgnorton pushed a commit that referenced this issue Feb 3, 2021
@davidby-influx @dgnorton
fix(query): Group By queries with offset that crosses a DST boundary …
099a125 
…can fail (#20277)

Customer reported that a GROUP BY query with an offset that caused an interval
to cross a daylight savings change inserted an extra output row off by one hour.
This fix ensured that the start time for the interval of a GROUP BY operator is
correctly set before calculating the time zone offset for that date and time.

Add TestGroupByIterator_DST() in query/iterator_test.go
for regression testing of this bug.

Fixes #20238

(cherry picked from commit df39b1e)

Fixes #20252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
area/queries kind/bug needs-backport/1.8 team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(query): Group By queries with offset that crosses a DST boundary can fail influxdata/influxdb
1 participant
@davidby-influx