Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: table view uses wrong heuristics to decide text or number for strings containing hex values #13592

Closed
mark-rushakoff opened this issue Apr 23, 2019 · 6 comments
Labels

Comments

@mark-rushakoff
Copy link
Contributor

Here is the raw data output of my query:

#group,false,false,false
#datatype,string,long,string
#default,_result,,
,result,table,_value
,,0,03435e1933247000
,,0,0380508833448000
,,0,03a26bc365a95000
,,0,03b7192c934fc000
,,0,3171e9b2ec5d12ed
,,0,6d7b04b1f3dc274a
,,0,a17df4ca53167736
,,0,f2dffd780a7bb955

As you can see, the _value column is all strings. When rendered as a table, the last two entries starting with a and f are displayed blue and left-justified; the other entries starting with a digit are displayed gray and right-justified.

Screen Shot 2019-04-23 at 2 56 04 PM

The CSS inspector indicates that the first group have CSS class .table-graph-cell__numerical.

IMO it would be better to simply inspect the #datatype row of the data to see that the column is of type string or long, and use that information to decide CSS classes. If a user has strings that they want rendered as numbers, they should be able to use toInt.

@stale
Copy link

stale bot commented Jul 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 28, 2019
@mark-rushakoff
Copy link
Contributor Author

I think this is still an issue.

@stale stale bot removed the wontfix label Jul 28, 2019
@russorat russorat added this to the Sprint 6 - Fluorite milestone Aug 2, 2019
@desa
Copy link
Contributor

desa commented Aug 2, 2019

@russorat @chnn collaborate on what new table UI will be

@russorat russorat removed this from the Sprint 6 - Fluorite milestone Aug 21, 2019
@stale
Copy link

stale bot commented Nov 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 19, 2019
@desa desa added stale-exempt and removed wontfix labels Nov 19, 2019
@russorat russorat removed their assignment Feb 18, 2020
@russorat russorat removed the epic/vis label Feb 18, 2020
@asalem1
Copy link
Contributor

asalem1 commented Mar 10, 2020

@mark-rushakoff I can't seem to reproduce this. Would you be able to take a look and see if this can be closed out?

@mark-rushakoff
Copy link
Contributor Author

Looks fixed now, thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants