-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: table view uses wrong heuristics to decide text or number for strings containing hex values #13592
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think this is still an issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@mark-rushakoff I can't seem to reproduce this. Would you be able to take a look and see if this can be closed out? |
Looks fixed now, thanks for following up. |
Here is the raw data output of my query:
As you can see, the
_value
column is all strings. When rendered as a table, the last two entries starting witha
andf
are displayed blue and left-justified; the other entries starting with a digit are displayed gray and right-justified.The CSS inspector indicates that the first group have CSS class
.table-graph-cell__numerical
.IMO it would be better to simply inspect the
#datatype
row of the data to see that the column is of type string or long, and use that information to decide CSS classes. If a user has strings that they want rendered as numbers, they should be able to usetoInt
.The text was updated successfully, but these errors were encountered: