Skip to content

Commit

Permalink
Fix the build on go1.3
Browse files Browse the repository at this point in the history
There was one remaining reference to an incomplete struct type from c
which is value_array. The error printed by the compiler is intermittent,
meaning it compiles sometimes and print the error sometimes. Also,
value_array isn't strictly an incomplete data type since it contains a
pointer to an unknown data type but it's size could be computed.
  • Loading branch information
jvshahid committed Jul 29, 2014
1 parent e8f7503 commit 22cb673
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ func GetValue(value *C.value) (*Value, error) {
v := &Value{}
v.Name = C.GoString(value.name)
var err error
v.Elems, err = GetValueArray(value.args)
v.Elems, err = GetValueArray((*C.value_array)(value.args))
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -706,7 +706,7 @@ func parseSelectQuery(q *C.select_query) (*SelectQuery, error) {
}

// get the column names
goQuery.ColumnNames, err = GetValueArray(q.c)
goQuery.ColumnNames, err = GetValueArray((*C.value_array)(q.c))
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 22cb673

Please sign in to comment.