Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nanosecond datetime string convertor #96

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 29, 2021

Closes #94

Proposed Changes

Some APIs can return date without nanosecond precision.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #96 (31102d7) into master (8f52ccc) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
+ Coverage     81.66%   81.88%   +0.22%     
  Complexity      379      379              
============================================
  Files            23       23              
  Lines           900      900              
============================================
+ Hits            735      737       +2     
+ Misses          165      163       -2     
Impacted Files Coverage Δ
src/InfluxDB2/ObjectSerializer.php 56.92% <100.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f52ccc...31102d7. Read the comment docs.

@bednar bednar requested a review from rhajek September 29, 2021 07:03
@bednar bednar marked this pull request as ready for review September 29, 2021 07:03
@bednar bednar merged commit 834fc2d into master Sep 29, 2021
@bednar bednar deleted the fix/nanosecond-trimming branch September 29, 2021 10:32
@bednar bednar added this to the 2.3.0 milestone Sep 29, 2021
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixDatetimeNanos() doesn't manage date time without nano precision
3 participants