Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid to use of eof over the stream => it not works on Windows #19

Merged
merged 5 commits into from
Apr 7, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 6, 2020

Closes #15

Fixed parsing QueryResponse on Windows

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added the bug Something isn't working label Apr 6, 2020
@bednar bednar added this to the 1.2.0 milestone Apr 6, 2020
@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #19 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
+ Coverage     85.02%   85.31%   +0.29%     
- Complexity      268      271       +3     
============================================
  Files            14       14              
  Lines           601      613      +12     
============================================
+ Hits            511      523      +12     
  Misses           90       90              
Impacted Files Coverage Δ Complexity Δ
src/InfluxDB2/FluxCsvParser.php 100.00% <100.00%> (ø) 57.00 <5.00> (+4.00)
src/InfluxDB2/QueryApi.php 97.29% <100.00%> (ø) 20.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7006a2...9d54f61. Read the comment docs.

@bednar bednar merged commit caa7ed5 into master Apr 7, 2020
@bednar bednar deleted the fix/csv-parser branch April 7, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser error
2 participants