Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue/604 #717

Merged
merged 6 commits into from
May 7, 2024
Merged

fix: Issue/604 #717

merged 6 commits into from
May 7, 2024

Conversation

KYankee6
Copy link
Contributor

@KYankee6 KYankee6 commented May 7, 2024

Closes #604

can tested other repos because there are unwanted infrastructure dependency (why it needs to connect localhost:9999?)

Proposed Changes

in flux-dsl, if ColumnRestriction has custom() function and it is using regular expression operator(such as "=~"), then it does not use double quotes.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (5effaa4) to head (4e32390).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #717   +/-   ##
=========================================
  Coverage     88.37%   88.37%           
- Complexity      784      786    +2     
=========================================
  Files           174      174           
  Lines          7089     7091    +2     
  Branches        390      391    +1     
=========================================
+ Hits           6265     6267    +2     
  Misses          698      698           
  Partials        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KYankee6,

Thank you for your Pull Request! 👍 I've gone ahead and addressed the code style errors that were causing our checks to fail. With those adjustments, all our checks have now passed successfully.

Everything looks good to me (LGTM)! 🚀 We're all set to move forward. Your contribution is greatly appreciated, and it's ready to make an impact.

Best regards

@bednar bednar merged commit 61c4500 into influxdata:master May 7, 2024
10 checks passed
@bednar bednar added this to the 7.1.0 milestone May 7, 2024
@KYankee6 KYankee6 deleted the Issue/604 branch May 10, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use Flux(v6.9.0) to filter through fuzzy(Imprecise) queries(regular expression)?
3 participants