Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: findTasksStream #647

Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat: findTasksStream #647

merged 6 commits into from
Nov 29, 2023

Conversation

Sciator
Copy link
Contributor

@Sciator Sciator commented Nov 23, 2023

Closes #646

Proposed Changes

adds findTasksStream

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@Sciator Sciator linked an issue Nov 23, 2023 that may be closed by this pull request
@Sciator Sciator force-pushed the 646-paging-for-find-tasks branch from ec8b0e2 to a0fa118 Compare November 23, 2023 12:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (347003a) 88.36% compared to head (ded0925) 88.39%.

Files Patch % Lines
...ava/com/influxdb/client/internal/TasksApiImpl.java 82.35% 3 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #647      +/-   ##
============================================
+ Coverage     88.36%   88.39%   +0.02%     
+ Complexity      779      777       -2     
============================================
  Files           172      172              
  Lines          7024     7058      +34     
  Branches        383      389       +6     
============================================
+ Hits           6207     6239      +32     
+ Misses          698      697       -1     
- Partials        119      122       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sciator Sciator requested a review from bednar November 27, 2023 11:31
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar added this to the 6.11.0 milestone Nov 29, 2023
@bednar bednar added the enhancement New feature or request label Nov 29, 2023
@bednar bednar merged commit 253e281 into master Nov 29, 2023
1 check passed
@bednar bednar deleted the 646-paging-for-find-tasks branch November 29, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paging for find Tasks
3 participants