Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove gson-fire dependency #446

Merged
merged 4 commits into from
Oct 19, 2022
Merged

chore(deps): remove gson-fire dependency #446

merged 4 commits into from
Oct 19, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 19, 2022

Closes #442

Proposed Changes

Removed gson-fire dependency from project. The discriminator type adapters are moved into JSON.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar changed the title Remove gson fire chore(deps): remove gson-fire dependency Oct 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 88.38% // Head: 88.40% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2874a4b) compared to base (687f31e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #446      +/-   ##
============================================
+ Coverage     88.38%   88.40%   +0.01%     
- Complexity      765      778      +13     
============================================
  Files           172      172              
  Lines          7010     7010              
  Branches        378      378              
============================================
+ Hits           6196     6197       +1     
+ Misses          694      693       -1     
  Partials        120      120              
Impacted Files Coverage Δ
...a/com/influxdb/client/internal/BucketsApiImpl.java 71.16% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar marked this pull request as ready for review October 19, 2022 08:24
@bednar bednar requested a review from michaelahojna October 19, 2022 08:30
@bednar bednar merged commit 4a3d45e into master Oct 19, 2022
@bednar bednar deleted the remove-gson-fire branch October 19, 2022 12:14
@bednar bednar added this to the 6.7.0 milestone Oct 19, 2022
sfeilmeier added a commit to OpenEMS/openems that referenced this pull request Nov 9, 2022
* Bump influxdb-client-java from 6.5.0 to 6.7.0 in /cnf
* Drop gson-fire as per influxdata/influxdb-client-java#446
* Update gson to 2.10.0 - see https://github.com/google/gson/blob/master/CHANGELOG.md


Bumps [influxdb-client-java](https://github.com/influxdata/influxdb-client-java) from 6.5.0 to 6.7.0.
- [Release notes](https://github.com/influxdata/influxdb-client-java/releases)
- [Changelog](https://github.com/influxdata/influxdb-client-java/blob/master/CHANGELOG.md)
- [Commits](influxdata/influxdb-client-java@v6.5.0...v6.7.0)

---
updated-dependencies:
- dependency-name: com.influxdb:influxdb-client-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump flux-dsl from 6.5.0 to 6.7.0 in /cnf

Bumps [flux-dsl](https://github.com/influxdata/influxdb-client-java) from 6.5.0 to 6.7.0.
- [Release notes](https://github.com/influxdata/influxdb-client-java/releases)
- [Changelog](https://github.com/influxdata/influxdb-client-java/blob/master/CHANGELOG.md)
- [Commits](influxdata/influxdb-client-java@v6.5.0...v6.7.0)

---
updated-dependencies:
- dependency-name: com.influxdb:flux-dsl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update bndrun, update gson, remove gson-fire

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stefan Feilmeier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gson-fire dependency from Java client
3 participants