chore: update d3 deps to use newer versions for d3-color security update #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update giraffe/packages.json to use: * d3-color ^3.1.0 * d3-format ^3.0.1 * d3-interpolate ^3.0.1 * d3-scale ^4.0.2 This resolves d3-color in devDependencies to 3.1.0 to fix a security issue.
…sion This resolves a yarn warning introduced in 4b61d6b.
|
I am re-opening this pull request and noting that we need to do something to get the build to pass. Right now, there is an error when running the jest tests on many of the files: The solution appears to be: https://stackoverflow.com/questions/49263429/jest-gives-an-error-syntaxerror-unexpected-token-export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update d3 deps to use newer versions for d3-color security update
Update giraffe/packages.json to use:
This resolves d3-color in devDependencies to 3.1.0 to fix a security
issue.
chore: package.json: use ^1.7.3 for shell-quote rather than exact version
This resolves a yarn warning introduced in 4b61d6b.
IMPORTANT: I've not tested this beyond verifying CI tests pass. Please advise if you'd like me to test manually.