Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone support to v3 SQL docs #5581

Merged
merged 14 commits into from
Oct 30, 2024
Merged

Add timezone support to v3 SQL docs #5581

merged 14 commits into from
Oct 30, 2024

Conversation

sanderson
Copy link
Collaborator

  • Updates information about time zones in SQL across all v3 products
  • Updates SQL data types documentation
  • Adds missing time and date functions
  • Adds information about how timezones change the behavior of some functions.
  • Rebased/mergeable

@telegraf-tiger
Copy link

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

jstirnaman
jstirnaman requested changes Aug 29, 2024
View reviewed changes
content/influxdb/cloud-dedicated/reference/sql/data-types.md Outdated Show resolved Hide resolved
content/influxdb/cloud-dedicated/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/cloud-dedicated/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/cloud-dedicated/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/cloud-dedicated/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/cloud-serverless/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/clustered/reference/sql/data-types.md Outdated Show resolved Hide resolved
content/influxdb/clustered/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/clustered/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
content/influxdb/clustered/reference/sql/functions/time-and-date.md Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger
Copy link

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@sanderson sanderson requested a review from jstirnaman August 29, 2024 19:13
jstirnaman
jstirnaman approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@jstirnaman jstirnaman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we need a note about the potential bug Jeff pointed out?

@sanderson
Copy link
Collaborator Author

@jeffreyssmith2nd I know this is an upstream bug. Are we going to hold off pushing the TZ support out until this bug is fixed? When should these doc changes go live?

@jeffreyssmith2nd
Copy link
Contributor

@jeffreyssmith2nd I know this is an upstream bug. Are we going to hold off pushing the TZ support out until this bug is fixed? When should these doc changes go live?

I don't know yet and am headed out for a long weekend. I'll check in with the team Tuesday on if we should delay or not.

Until then, I think we should hold the docs changes.

jstirnaman
jstirnaman requested changes Aug 29, 2024
View reviewed changes
content/influxdb/cloud-serverless/reference/sql/functions/time-and-date.md Outdated

Converts a value to a date (`YYYY-MM-DD`).
Supports strings and numeric types as input.
Strings are parsed as `YYYY-MM-DD` unless another format is specified. if no Chrono formats are provided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete sentence

Strings are parsed as YYYY-MM-DD unless another format is specified. if no Chrono formats are provided.

?

@sanderson
Copy link
Collaborator Author

@jstirnaman I think you may have been viewing the diff of an old commit. I went through and fixed all of those.

@sanderson sanderson requested a review from jstirnaman August 29, 2024 21:26
@jeffreyssmith2nd
Copy link
Contributor

@sanderson Still on hold for the docs changes, waiting on some upstream discussion on if the ::timestamp thing is actually a bug or if it is intended behavior.

In the meantime, I'm removing all references to it in the docs where it isn't necessary to prevent any confusion for people down the line.

I will update the blog post and make a corresponding PR here as well once we know for sure what behavior we want out of ::timestamp

@jeffreyssmith2nd
Copy link
Contributor

@sanderson This can be rolled out whenever you are ready, thanks for your help and patience with this one!

@sanderson sanderson merged commit 4045a6c into master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyssmith2nd jeffreyssmith2nd jeffreyssmith2nd left review comments

@jstirnaman jstirnaman jstirnaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderson @jeffreyssmith2nd @jstirnaman