Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade golang to 1.18 #5897

Merged
merged 24 commits into from
Apr 21, 2022
Merged

chore: upgrade golang to 1.18 #5897

merged 24 commits into from
Apr 21, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Mar 23, 2022

This PR

  • upgrades chronograf to use golang1.18
  • checks that go modules are tidy in every running test
  • checks that go files are formatted according to go fmt rules

Moreover, it upgrades the builder image to use ubuntu 20.04

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

@sranka
Copy link
Contributor Author

sranka commented Mar 23, 2022

We can proceed with this once #5875 is merged, the docker build succeeds locally.

@sranka
Copy link
Contributor Author

sranka commented Mar 24, 2022

@ivankudibal please build and publish the builder image as described in etc/README.md, I am not authorized to publish it.

@sranka sranka requested a review from ivankudibal April 1, 2022 10:32
@sranka sranka marked this pull request as ready for review April 4, 2022 12:40
@sranka
Copy link
Contributor Author

sranka commented Apr 4, 2022

@ivankudibal thank you for the new builder image, pls proceed to review/approval of this PR

@sranka sranka added this to the 1.10 milestone Apr 19, 2022
@sranka sranka merged commit d698c2b into master Apr 21, 2022
@sranka sranka deleted the chore/go_1.18 branch April 21, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants