Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP(iox-10350): patched df upgrade 2024-03-31 (ver 37.0.0) #5

Closed
wants to merge 3 commits into from
Closed

WIP(iox-10350): patched df upgrade 2024-03-31 (ver 37.0.0) #5

wants to merge 3 commits into from

Conversation

wiedld
Copy link
Collaborator

@wiedld wiedld commented Apr 5, 2024 •
edited
Loading

⚠️ This will not be merged. ⚠️

What's in this branch:

  1. Bringing us up to datafusion 37.0.0

    • EOD on 2024-03-31 is this commit: 
      commit cd7a00b08309f7229073e4bba686d6271726ab1c
Author: wiedld <[email protected]>
Date:   Sun Mar 31 05:09:06 2024 -0700

    fix(9870): common expression elimination optimization, should always re-find the correct expression during re-write. (#9871)

  2. PATCH: add the named struct patch

    commit 66f4fcb4664fc797ffb046d5b2ebcfca65ba4cd7
Author: Andrew Lamb <[email protected]>
Date:   Tue Apr 2 17:21:02 2024 -0400

    Use `struct` instead of `named_struct` when there are no aliases (#9897)

  3. PATCH: include the patch request (per slack) for the upstream coalesce bug.

    commit f0eec349a1abed14bcb2ee8a9fbf98bbb19b8f9a (HEAD -> iox-10350/df-upgrade-2024-03-31)
Author: Lordworms <[email protected]>
Date:   Fri Apr 5 15:57:48 2024 -0500

    coercion vec[Dictionary, Utf8] to Dictionary for coalesce function (#9958)

  4. PATCH: patch for the function re-writer, visiting subqueries within expressions.

    commit e8de1c612a986ae4b0348ce0a9d92f08d93c258c
Author: Andrew Lamb <[email protected]>
Date:   Wed Apr 10 11:14:02 2024 -0400

    fix NamedStructField should be rewritten in OperatorToFunction in subquery

alamb and others added 3 commits April 5, 2024 12:40
@alamb @wiedld
Use struct instead of named_struct when there are no aliases (apa…
66f4fcb 
…che#9897)

* Revert "use alias (apache#9894)"

This reverts commit 9487ca0.

* Use `struct` instead of `named_struct` when there are no aliases

* Update docs

* fmt
@Lordworms @wiedld
coercion vec[Dictionary, Utf8] to Dictionary for coalesce function (a…
f0eec34 
…pache#9958)

* for debug

finish

remove print

add space

* fix clippy

* finish

* fix clippy
@alamb @wiedld
fix NamedStructField should be rewritten in OperatorToFunction in sub…
e8de1c6 
…query
@wiedld wiedld force-pushed the iox-10350/df-upgrade-2024-03-31 branch from 00f95d7 to e8de1c6 Compare April 10, 2024 20:02
@wiedld wiedld changed the base branch from main to base/df-upgrade-2024-03-31 April 10, 2024 20:04
This was referenced Apr 16, 2024
Closed
Closed
Closed
@appletreeisyellow appletreeisyellow mentioned this pull request Apr 23, 2024
Closed
@wiedld wiedld mentioned this pull request Apr 24, 2024
Closed
@appletreeisyellow appletreeisyellow mentioned this pull request Apr 24, 2024
Closed
@appletreeisyellow
Copy link

The upgrade is done. Closing

@appletreeisyellow appletreeisyellow deleted the iox-10350/df-upgrade-2024-03-31 branch April 29, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiedld @appletreeisyellow @alamb @Lordworms