Looks like a bug in pg adapter

[apneadiving]

I'd like to understand why we have almost same code in abstract and pg adapters, only difference is a call to environmentify which looks legit in abstract but is not present in pg's.
So I think I could remove the code in pg's and only rely on the abstract controller. Would be cool to have confirmation. Thanks

[bradrobertson]

Ya I think you're right. Looks like they're not doing anything different other than environmentify.

Note that the concept of environmentify should (has) changed to be more of a "translate this tenant name into some other tenant name" and environmentify was the original implementation of this (translate "tenant1" to "tenant1-development".

I'd love to abstract that out to just be a proc that someone can configure that receives the tenant name and returns the translated name that works for ALL adapters (not just connection based). I just don't have any time to actually do this unfortunately. There's an open issue to this affect but I don't think anything has come from it

[apneadiving]

ok, so do you mind if I just remove the confusing override in pg's adapter?

[bradrobertson]

sure