-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_sql configuration and bithub_development #151
Comments
Hey, check #128 for fix. |
@vdragsic: any ideas on when your pull request might be accepted and merged into the next release? |
according to the comments in that issue, there is an issue with the fix. I haven't personally played with it and I have to apologize, but I hardly have time for my own job these days. If you guys can figure it out, come to some solid conclusions, I'd love to hear it. |
I'll try to figure something out about that excluded tables vs migrations issue in next few days. |
I have been circling around to the various issues trying to clarify for myself what is required to get this feature acceptable. I have a relatively simple use case of a multi-tenant application in which each tenant has its own subdomain and segregation happens by setting the schema path based on the subdomain of the request url. The only excluded model is an Account model that is accessed in the public schema and has no relations and is simply used to keep track of the tenant schemas. I however am trying to do a Postgres full-text search across multiple models using a View and creating new schemas from structure is quite useful. In answer to this comment: right now this feature is working for me out of the box. I am using the version from develop that does not have the excluded_models but I don't think it would hurt me either way. (I do still have an issue with the reference to the bithub_development database but I believe that is a minor fix and is addressed as part of #128). As a note of explanation to Brad my understanding is that this feature uses its own dump of just the default schema. Migrations still end up unfortunately dumping all schemas into the db/structure file by the default rails tasks which is probably why @vdragsic avoided using that. In response to this thread: I also am finding it hard to understand why there is the need to exclude models in the structure dump though honestly I have not fully grasped all the nuances of how these various features interact with each other in different contexts. I do wonder if there couldn't be some more intelligent though complicated Regex replacements for setting correct schemas on foreign_keys tables of excluded_models. If this were even possible I almost feel like it should be a different feature in a more advanced use case with its own configuration settings. I am curious how much of this is making sense to others and would love to get feedback so I can further understand the situation and possibly even help with implementation. |
**Implemented enhancements:** - Increase errors visibility by showing more information on the underlying error rather than a generic error 'Apartment::TenantNotFound' (influitive#176) - Resolved influitive#177 - Added rails 7 support (influitive#178) **Fixed bugs:** - Fixing tenant_presence_check config in the README (influitive#180) - Resolved influitive#161 and influitive#81 - Fixed sequence name (influitive#187) **Closed issues:** - Resolved influitive#151 - removed reloader and console overwrite of reload method (influitive#174)
I noticed in the Readme the option to use_sql for creating new schemas but found that this feature was not in the latest release. I am wondering when this feature might be released.
I ended up pointing my Gemfile to the development branch for now but there is an issue with a reference to 'bithub_development' in PostgresqlSchemaFromSqlAdapter#pg_dump_schema_migrations_data. I believe it is a simple fix but thought I should let you know.
The text was updated successfully, but these errors were encountered: