Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error types back to tuples #762

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

nicholastmosher
Copy link
Contributor

@nicholastmosher nicholastmosher commented Feb 8, 2021

A little while ago I made the mistake of turning a bunch of error types into struct-variants. This makes it very difficult to pattern match on errors when we need to inspect them. I would like to change them back to being tuple-variants.

Updating the error enums is a breaking change, so I will open this PR now, and we can either merge it right away or we can wait until we are already ready to do a version bump on a few crates and we can include this in those changes.

The main motivation behind doing this is that it will make implementing things like #580 much easier

@sehz
Copy link
Contributor

sehz commented Feb 9, 2021

Rebase please

@sehz sehz merged commit 63202b9 into infinyon:master Feb 9, 2021
@nicholastmosher nicholastmosher deleted the tuple-errors branch February 9, 2021 21:33
simlay pushed a commit that referenced this pull request Feb 25, 2021
* Change error types back to tuples

* Bump all crates with breaking changes from errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants