Cluster refactor: Split out SysInstaller, simplify check-fixes #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
sehz
requested changes
Jan 27, 2021
|
It'd be nice to merge and publish infinyon/fluvio-helm#11 before this, so that we can bump our dependency to fluvio-helm:0.4.1 and use the latest version. The big benefit there is that the new fluvio-helm updates do not forward all of the noise from the helm command |
sehz
pushed a commit
to sehz/fluvio
that referenced
this pull request
Feb 2, 2021
…yon#721) * Consolidate start and upgrade checks * Factor out SysInstaller from k8 and local installers * Fix broken intra-doc links * Add 'attempt_fix' to ClusterCheck * Add progress rendering checks to K8Installer * Move check implementations into ClusterCheck impls * Apply cargo fmt * Apply cargo clippy * Add builder method for conditional chaining * Bump fluvio-helm dependency to 0.4.1
simlay
pushed a commit
that referenced
this pull request
Feb 25, 2021
* Consolidate start and upgrade checks * Factor out SysInstaller from k8 and local installers * Fix broken intra-doc links * Add 'attempt_fix' to ClusterCheck * Add progress rendering checks to K8Installer * Move check implementations into ClusterCheck impls * Apply cargo fmt * Apply cargo clippy * Add builder method for conditional chaining * Bump fluvio-helm dependency to 0.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good start to some refactoring that's needed in the cluster crate. In this PR I've extracted the sys chart installation logic into its own
SysInstallertype, which means we have less code duplication and cross-dependency between the Local and K8 installers.Another change here is that I've added an
attempt_fixoptional function to theClusterChecktrait, which allows instances of that trait to define the means by which it can attempt to fix a failed check. Previously, this fixing logic was very far removed from the check itself, so this consolidates things nicely. It also has the effect of unblocking the "incremental progress checks" for the k8 installer. Now, using the k8 installerfluvio cluster startwill print checking outputs as they are run, the same way thatfluvio cluster start --localalready does today.This checks a number of the boxes from #705