Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - build: update k8 crates #3546

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - build: update k8 crates #3546

wants to merge 1 commit into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Sep 19, 2023 •
edited by bors bot
Loading

No description provided.

@morenol morenol force-pushed the update-k8-crates branch 4 times, most recently from c713574 to 1b1df54 Compare September 19, 2023 16:26
@morenol morenol marked this pull request as ready for review September 19, 2023 16:27
@morenol morenol requested a review from sehz September 19, 2023 16:27
sehz
sehz requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. couple of nits

crates/fluvio-cli/src/error.rs Outdated Show resolved Hide resolved
crates/fluvio-cli/src/profile/sync/k8.rs Outdated Show resolved Hide resolved
@morenol morenol requested a review from sehz September 19, 2023 17:38
sehz
sehz approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morenol
Copy link
Contributor Author

morenol commented Sep 19, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 19, 2023
@morenol
build: update k8 crates (#3546)
d2229bf
@bors
Copy link

bors bot commented Sep 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title build: update k8 crates [Merged by Bors] - build: update k8 crates Sep 19, 2023
@bors bors bot closed this Sep 19, 2023
@morenol morenol deleted the update-k8-crates branch September 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morenol @sehz