Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fluvio #432

Merged
merged 2 commits into from
Jun 20, 2024
Merged

chore: update fluvio #432

merged 2 commits into from
Jun 20, 2024

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Jun 20, 2024

No description provided.

@morenol morenol requested a review from digikata June 20, 2024 14:25
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -30,8 +30,7 @@ jobs:
run: |
# work around cargo bug
#cargo add fluvio --git https://github.com/infinyon/fluvio --branch master
sed -i "s/fluvio = { features = .*/fluvio = { features = \[\"admin\"\], git = \"https:\/\/github.com\/infinyon\/fluvio.git\" }/g" Cargo.toml

sed -i.bak "s/tag = "\(.*\)"/branch = "master"/g" Cargo.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this is too general a replacement, but if fluvio deps are the only ones to use git tag/branch it should be fine. Also wondering cargo add is fixed to update git repos dep links again. But let's go ahead on this, latest-dev-fluvio is a noncritical workflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is too general, but as you said we only use git tag right now for fluvio dependencies

@morenol morenol merged commit a3dde25 into main Jun 20, 2024
12 checks passed
@morenol morenol deleted the update-fluvio branch June 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants