Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Fluvio::connect_with_config, add FluvioConfig #300

Merged
merged 3 commits into from
Aug 21, 2023
Merged

feat: Implement Fluvio::connect_with_config, add FluvioConfig #300

merged 3 commits into from
Aug 21, 2023

Conversation

ozgrakkurt
Copy link
Contributor

This PR adds the Fluvio::connect_with_config method. It also adds FluvioConfig structure to be used along with the added method.

closes #287

@ozgrakkurt ozgrakkurt requested a review from digikata August 21, 2023 12:08
@ozgrakkurt ozgrakkurt self-assigned this Aug 21, 2023
@ozgrakkurt ozgrakkurt requested a review from morenol August 21, 2023 12:09
digikata
digikata approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice turnaround!

@ozgrakkurt ozgrakkurt merged commit 96e4644 into main Aug 21, 2023
@bors bors bot deleted the connect-with-config branch August 21, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@morenol morenol Awaiting requested review from morenol

Assignees

@ozgrakkurt ozgrakkurt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Fluvio.connect_with_config to client
2 participants
@ozgrakkurt @digikata