Feature/tests #302
Feature/tests #302
Conversation
iruzevic
added
bugfix
Codecov Report
@@ Coverage Diff @@
## develop #302 +/- ##
=============================================
+ Coverage 79.74% 80.97% +1.22%
+ Complexity 1187 1186 -1
=============================================
Files 131 131
Lines 3584 3584
=============================================
+ Hits 2858 2902 +44
+ Misses 726 682 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -4,7 +4,6 @@ | |||
| "system", | |||
There was a problem hiding this comment.
Can you check which ones are being redefined from BrainMonkey when and just remove the ones we are not mocking?
| @@ -201,6 +222,7 @@ private function getGeolocation(): string | |||
| $ipAddr = $this->getIpAddress(); | |||
| } | |||
|
|
|||
|
|
|||
| $mock->shouldReceive('setCookie')->withArgs(function (string $name, string $value) { | ||
| putenv("ES_SIDEAFFECT={$name}"); | ||
| putenv("ES_SIDEAFFECT_ADDITIONAL={$value}"); | ||
| }); |
There was a problem hiding this comment.
I think you should probably return in closures when using withArgs, see http://docs.mockery.io/en/latest/reference/expectations.html?highlight=withArgs#argument-matching-with-closures
Co-authored-by: Denis Žoljom <[email protected]>
Co-authored-by: Denis Žoljom <[email protected]>
Co-authored-by: Denis Žoljom <[email protected]>
Co-authored-by: Denis Žoljom <[email protected]>
* develop: Feature/tests (#302) Add lock true to composer json config # Conflicts: # src/Geolocation/AbstractGeolocation.php # tests/Blocks/BlockVariationCliTest.php # tests/Geolocation/AbstractGeolocationTest.php # tests/Helpers.php
Description