Feature/project structure update #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba40efd.
Carthage currently doesn't work with Moya - Moya/Moya#2165
Updated encoder and decoder tests
Dundo7
approved these changes
Aug 31, 2021
Truba
approved these changes
Sep 1, 2021
Japx.podspec
Outdated
| s.subspec 'ObjC' do |sp| | ||
| sp.source_files = 'Japx/Classes/ObjC/**/*' | ||
| sp.dependency 'Japx/Core' | ||
| s.subspec "ObjC" do |sp| |
There was a problem hiding this comment.
Why did you change everything to double quotes?
I was under the impression single quotes should be used in ruby as a default, and double only if we need string interpolation 🤔
There was a problem hiding this comment.
Not sure to be honest, I didn't notice it - probably my ruby linter in VS code changed it to double quotes
|
@Truba please check again |
Truba
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we've added Carthage and SwiftPM support