ERR_UNSUPPORTED_DIR_IMPORT when used in esm project

[asokani]

I’m unable to run my ESM project with this library due to the following error:

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/app/node_modules/buffer/' is not supported resolving ES modules imported from /app/node_modules/nsfwjs/dist/esm/index.js

The issue is caused by this line in dist/esm/index.js

import { Buffer } from "buffer/";

It can be fixed like this:

import { Buffer } from "buffer";

It might be possible to address this here:

nsfwjs/src/index.ts

Line 3 in 836ff6b

import { Buffer } from "buffer/";

[mazenchami]

@asokani thank you for opening this issue.

This was resolved in #898 and released in v4.2.1.

I'll be closing out this issue now but please reopen it if I miss understood your comment.

[asokani]

Sorry, you are missing the point. The problem is, the added "slash" in the v4.2.1 broke the ESM version of the library.

See this example: https://github.com/asokani/nsfwjs-esm

$ node dist/index.js
node:internal/process/esm_loader:46
      internalBinding('errors').triggerUncaughtException(
                                ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/tmp/nsfw-esm/node_modules/buffer/' is not supported resolving ES modules imported from /tmp/ee/node_modules/nsfwjs/dist/esm/index.js
Did you mean to import buffer/index.js?
    at new NodeError (node:internal/errors:405:5)
    at finalizeResolution (node:internal/modules/esm/resolve:218:17)
    at moduleResolve (node:internal/modules/esm/resolve:838:10)
    at defaultResolve (node:internal/modules/esm/resolve:1036:11)
    at DefaultModuleLoader.resolve (node:internal/modules/esm/loader:251:12)
    at DefaultModuleLoader.getModuleJob (node:internal/modules/esm/loader:140:32)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:33)
    at link (node:internal/modules/esm/module_job:75:36) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///tmp/nsfw-esm/node_modules/buffer/'
}

Node.js v20.5.0

However, I cannot reopen this issue - there's just a "comment" button. Can you @mazenchami please recheck?

[ghnp5]

Having the same problem.

The line needs to import from buffer/index.js and not just buffer/.

Or just buffer as was before. Version 4.2.0 works for me, still.

@mazenchami

[haZya]

The issue related to the bun runtime seems to have been fixed (oven-sh/bun#8683). It should be safe to remove the trailing slash now if that's causing any issues for others. Also in my testing, I couldn't reproduce any issue related to this on bun. Maybe someone can provide an example to reproduce this on bun if it still exists without the trailing slash.

Also, since buffer is a peer dep of this library I think installing buffer directly on the project and importing it on the main entry file should fix any issues without needing a trailing slash. 🤔