Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme switch support #3568

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Theme switch support #3568

wants to merge 38 commits into from
+1,686 −1,215

Conversation

isthaison
Copy link
Contributor

@isthaison isthaison commented Nov 21, 2024 •
edited by yingfeng
Loading

What problem does this PR solve?

  • New Feature (non-breaking change which adds functionality)

@yingfeng yingfeng added the ci Continue Integration label Nov 22, 2024
@isthaison
Copy link
Contributor Author

I have added theme feature , and fixed error when api return no chunk in Page searching, Hope it will help your project
Recording2024-11-22113727-ezgif com-video-to-gif-converter

@cike8899
Copy link
Contributor

There are many display issues in night mode, such as

image

@isthaison
Copy link
Contributor Author

image
I 've update for flow. @cike8899 , please check again

@isthaison
Copy link
Contributor Author

hi @cike8899 . In this project css declaration is separate, it is difficult to check all ui components. Can you check again, thank you

@cike8899
Copy link
Contributor

image
image
image
image
image
image
image
image

@isthaison
Copy link
Contributor Author

@cike8899 please check again

@isthaison
Copy link
Contributor Author

cc @yingfeng

@cike8899
Copy link
Contributor

image
image
image

@isthaison
Copy link
Contributor Author

@cike8899 please check again

@cike8899
Copy link
Contributor

image
image

@isthaison
Copy link
Contributor Author

Hi @cike8899. Please check again. Hope it will be ok

@cike8899
Copy link
Contributor

image
image

@isthaison
Copy link
Contributor Author

Hi @cike8899, Let's continue

@cike8899
Copy link
Contributor

image
image
image

@isthaison
Copy link
Contributor Author

image
if it drags on it will never end because of the updates

@isthaison
Copy link
Contributor Author

@cike8899 please try again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cike8899 cike8899 Awaiting requested review from cike8899

Assignees
No one assigned
Labels
ci Continue Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isthaison @cike8899 @yingfeng