allowing docker container to access service on host #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzhichang
reviewed
Oct 18, 2024
docker/docker-compose-base.yml
Outdated
| @@ -46,7 +46,7 @@ services: | |||
| ports: | |||
| - ${MYSQL_PORT}:3306 | |||
| volumes: | |||
| - mysql_data:/var/lib/mysql | |||
| - ./mysql_data:/var/lib/mysql | |||
There was a problem hiding this comment.
mysql_data is a volume defined later in this yaml. It's mounted from a docker managed directory.
In rare case if you want to mount from some specific host path, change the volume definion there for yourself.
Revert this chagne please.
yuzhichang
reviewed
Oct 18, 2024
| @@ -29,3 +29,5 @@ services: | |||
| networks: | |||
| - ragflow | |||
| restart: always | |||
| extra_hosts: | |||
| - "host.docker.internal:host-gateway" | |||
yuzhichang
changed the title
|
I reverted the change of |
Halfknow
pushed a commit
to Halfknow/ragflow
that referenced
this pull request
Nov 11, 2024
### What problem does this PR solve? 1. services running (e.g., ollama) running on the host could not be accessed from docker containers ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) --------- Co-authored-by: Zhichang Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
making mysql container unable to start, 44a9152 fixes it.
Type of change