Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use user-defined rerank model's top_k parameter when knowledge Q&A conversation #1396

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

hwzhuhao
Copy link
Contributor

@hwzhuhao hwzhuhao commented Jul 5, 2024

What problem does this PR solve?

During knowledge Q&A conversations, the user-defined rerank model's top_k parameter was not used

#1395

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@KevinHuSh KevinHuSh merged commit dcb3fb2 into infiniflow:main Jul 8, 2024
1 check passed
Halfknow pushed a commit to Halfknow/ragflow that referenced this pull request Nov 11, 2024
…&A conversation (infiniflow#1396)

### What problem does this PR solve?

During knowledge Q&A conversations, the user-defined rerank model's
top_k parameter was not used

infiniflow#1395 

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants