Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Hope to add rerank models to the project #724

Closed
1 task done
xxxl123 opened this issue May 11, 2024 · 7 comments
Closed
1 task done

[Feature Request]: Hope to add rerank models to the project #724

xxxl123 opened this issue May 11, 2024 · 7 comments
Labels

Comments

@xxxl123
Copy link

xxxl123 commented May 11, 2024

Is there an existing issue for the same feature request?

  • I have checked the existing issues.

Is your feature request related to a problem?

No response

Describe the feature you'd like

I think RAG+re-rank is a great combination that can improve recall accuracy.

Describe implementation you've considered

No response

Documentation, adoption, use case

No response

Additional information

No response

@Nuclear6
Copy link

I see that there is a rerank module in the project architecture diagram. Does the module they provide fail to meet the requirements? Or some other problem?
image
image

@xxxl123
Copy link
Author

xxxl123 commented May 13, 2024

I see that there is a rerank module in the project architecture diagram. Does the module they provide fail to meet the requirements? Or some other problem? image image

I asked the developers, and they haven't added the rerank model yet.

@Nuclear6
Copy link

What you mean is that the rerank here is only based on some strategies to achieve the effect of rerank, and does not involve reranking LLM, right?

@xxxl123
Copy link
Author

xxxl123 commented May 13, 2024

image
There should be a rearranging strategy, but the rerank model was not used.

@Nuclear6
Copy link

So I have a question, what rerank models are available here? Have you ever compared the results?

@KevinHuSh
Copy link
Collaborator

Weighted keywords and embedding similarity is RAGFlow's reranking model right now.
And we're working on replacing the embedding similarity with other so called rerank models like BGE reranker and others.

@xxxl123
Copy link
Author

xxxl123 commented May 13, 2024

I think the accuracy of the recall is already very accurate now, and I hope it can be further improved. It shouldn't be worse after adding it.

cike8899 added a commit to cike8899/ragflow that referenced this issue May 29, 2024
KevinHuSh pushed a commit that referenced this issue May 29, 2024
### What problem does this PR solve?

Vector similarity weight is displayed incorrectly #965
feat: add rerank models to the project #724 #162
### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
@KevinHuSh KevinHuSh mentioned this issue May 29, 2024
1 task
KevinHuSh added a commit that referenced this issue May 29, 2024
### What problem does this PR solve?

feat: add rerank models to the project #724 #162

### Type of change

- [x] New Feature (non-breaking change which adds functionality)
KevinHuSh added a commit that referenced this issue May 29, 2024
### What problem does this PR solve?

#724 #162

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] New Feature (non-breaking change which adds functionality)
Halfknow pushed a commit to Halfknow/ragflow that referenced this issue Nov 13, 2024
…nfiniflow#966)

### What problem does this PR solve?

Vector similarity weight is displayed incorrectly infiniflow#965
feat: add rerank models to the project infiniflow#724 infiniflow#162
### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
Halfknow pushed a commit to Halfknow/ragflow that referenced this issue Nov 13, 2024
### What problem does this PR solve?

feat: add rerank models to the project infiniflow#724 infiniflow#162

### Type of change

- [x] New Feature (non-breaking change which adds functionality)
Halfknow pushed a commit to Halfknow/ragflow that referenced this issue Nov 13, 2024
### What problem does this PR solve?

infiniflow#724 infiniflow#162

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] New Feature (non-breaking change which adds functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants