Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ReactDom.hydrate in inferno-compat #1270

Closed
xkxx opened this issue Feb 3, 2018 · 4 comments
Closed

Support ReactDom.hydrate in inferno-compat #1270

xkxx opened this issue Feb 3, 2018 · 4 comments

Comments

@xkxx
Copy link
Contributor

xkxx commented Feb 3, 2018

Hello awesome inferno maintainers!

It would be great to support hydrate in inferno-compat, for maintaining React 16 compatibility.

I encountered this issue when I was researching using Inferno with next.js, as their latest version uses React 16 functionalities (vercel/next.js#3264). This was brought up briefly in #1239. One of the really cool thing with inferno is that it's compatible with React, so it would be really nice to have this feature!

Any idea how much work this would be and how we can help push this feature through?

Best,

xkxx

@Havunen
Copy link
Member

Havunen commented Feb 3, 2018

Ok, this is simple thing. It seems like React17 is deprecating hydration by render https://reactjs.org/docs/react-dom.html#hydrate

We can do the same in v5. I will rename and add hydrate to Inferno core.

@Havunen
Copy link
Member

Havunen commented Feb 3, 2018

I will rename hydrateRoot to hydrate so its same as React. and add it to inferno-compat and inferno packages. It was internal method previously so there should be no breaking change.

@Havunen
Copy link
Member

Havunen commented Feb 3, 2018

I just published new version of next 4.0.0-18 hydrate is available there.

@Havunen Havunen closed this as completed Feb 3, 2018
@xkxx
Copy link
Contributor Author

xkxx commented Feb 3, 2018

Wow cool, thanks for the super quick response and fix!

I guess I could contribute by updating the docs :) I'll start on that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants