Option to change/turn off default phone number suggestions #25
Labels
Comments
|
Yes, this is on my list. |
Closed
barryo
added a commit
that referenced
this issue
Apr 2, 2017
* patch panel management * patch panel management * [DB] Add fields for duplex ports * patch panel management * patch panel port management 2017-01-30 * [DB] Fix for schema. Applies cleanly to current production schema. * [REVIEW] Refactor to use route groups. Grouping makes the routes file easier to understand, removes unnecessary URL and namespace prefixes. It also makes it easier to find routes related to a particular function. Removed the older (pre-Laravel 5.2) as/uses syntax for named routes and replaced with ->name(). No other changes made. * [REVIEW] Use of optional parameters Routes that take an optional parameter do not need two entries - use the optional parameter indication: '?' Are there cases where the id for edit and view would be optional? I wouldn't have thought so but I haven't looked at the controller yet. * [REVIEW] No trailing slashes on URLs * [REVIEW] Remove duplicate * [REVIEW] Remove duplicate name Please check that this is okay. * [HK] This is for debug only and it is set up in app/Providers/AppSericeProvider * [HK] Package updates * [HK] IDE library search path updates * [REVIEW] Create separate routes file for routes needing authentication Over-riding the route's middleware in the constructor may lead to confusion / security errors as we /typically/ do not expect to find them there. They're either defined based on the routes file (see app/Providers/RouteServerProvider) or set / changed on the route definition itself. * [REVIEW] It will always be bootstrap3 so make it "global" * [REVIEW] Fix last commit re Former * [REVIEW] No need to copy arrays and pass them around Also created two useful methods. * [REVIEW] No need to encase params in a "params" array Foil / Blade templates and effecitvily name spaced and parameter names only exist within the template. * [REVIEW] More concise templates using ternary operatior * [HK] IDE helper files * [IM] Refactor to make superuser actions explicit * patch panel port management 2017-01-31 * [REVIEW] A lot of refactoring - change port name from 'name' to number - move port prefix from port name to panel - use request objects: https://laravel.com/docs/5.4/validation - better naming / naming consistency * patch panel port management 2017-01-31 * [REVIEW] Improve utility functions and view of patch panel list * [REVIEW] Patch panel 'delete' action Some notes: 1) we don't normally use the full namespace of facades: ``` -use Illuminate\Support\Facades\Input; -use Illuminate\Support\Facades\Redirect; -use Illuminate\Support\Facades\Validator; ``` 2) the id for the delete routye is mandatory so we can lose: ``` if($id != null){ ``` 3) ensure refernced patch panel exists or abort(404) 4) it's more traditional to use redirect() rather than Redirect::to() * [REVIEW] Frotnend check for delete - needs work @mtxmotorax - can you have a second look at this? See other examples from IXP Manager: 1) cannot have a modal for every table row, this does not scale 2) need an undelete (or 'make active') option also Typically we'd use https://api.jquery.com/attribute-contains-prefix-selector/ on the id ( id='list-delete-XXX' ) and generate a pop up from that. * [IM] Better display panel utilisation including duplex ports * patch panel port management 2017-02-01 * [BF] - patch panel issues * [N+] - popup delete patch panel + possibility to reactivate a patch panel * add new popup library * [REVIEW] - Patch panel port * [IM] - Customer overview display patch panel informations * [IM] - Customer overview display patch panel informations * [REVIEW] Small style changes * [IDE] file updates * [REVIEW] Work with yann inc. DB changes * [REVIEW] - Customer overview ports * [REVIEW] - Customer overview Cross connects * [Review] - Patch Panel Port Management + Patch panel port history * [N+] patch panel port history new files * [HK] composer update * [REVIEW] Small tweaks * [DB] Add schema for patch panel files * [REVIEW] - Patch panel port + allocate mode * [HK] - .iml file * [DB] Scafolding for patch panel port files * [DB] Schema changes @mtxmotorax - can you update entities to match xml schema? * [MERGE] * [MERGE] * Add FontAwesome * [REVIEW] - allocate mode - notes - fix issue * [N+] - Patch panel port file upload system * [REVIEW] - PPP view / PPP history * ppp email * IDE updates * [N+] - Patch panel port email + LoA PDF * Ignore but create files dir * [N+] - LoA PDF + LoA Email * Review with @mtxmotorax * Continued review with @mtxmotorax - work in progress * [REVIEW] Clearer call to action * Add HTML Purifier (useful to clean html to prevent xss issues) * [NF] Alerts helper for Laravel @mtxmotorax - see the next commit and referenced issue for usage. We need to be better at documentation and to this end, here's the simple docs for this: Commit: https://github.com/inex/ixp-manager-docs/commit/e51a18bbf65c359c5c432a831b374aaaa935151a Docs: https://ixp-manager.readthedocs.io/en/latest/dev/helpers.html * [IM] Helper used for alerts * Remove unused paramaters - example as promised for #17 * Correct docblocks for correct IDE interpretation * Refactor API calls - example as promised for #17 * [HK] remove unused route and debugging entry * [REVIEW] - URL modification respecting URL policy * Separate JavaScript and HTML * [NF] New API call to get all the details of a patch panel port * Fix files export * Phase 1 in refactoring notes dialog * Quick fix * [REVIEW] - URL policy * [REWIEW] - Code formating + alert helper for PPP * [REVIEW] - New Note format * Revert regression introduced in 142db2a * [API] Add "deeper" option for patch panel ports * Intermediatary step I do not want to lose * Next iteration of cleaning js * Better handling and docs * [REVIEW] - #17 URL styles / #18 Refractor API (patch panels) * [REVIEW] - #19 Separate JS from HTML (Patch Panels) * [REVIEW] - code formatting * More JS cleanup * Add events * Code fixes. * More tidying of index php/hs * [REVIEW] - patch panel naming variable / code review * Large clean up of file uploads * Some major refactoring of API calls * [REVIEW] - code formating patch panel port * [REVIEW] - fixing minor issues / code format patch panel port * minor change * minor change * fix merge * fix merge * [N+] - New Patch panel Port state: Reserved (#23) * [N+] - Add Chargeable to patch panel - fixes #24 * [REVIEW] - code formatting * [REVIEW] - fix bug note system + code review JS * [DB] schema required for #5 * [REVIEW] - JS comment * [N+] - layer 2 interface management * Minor tweaks to patch panel management * Use customer width classes with Former * Help messages, etc. * [HK] - fix minor merge issue * Use bower for third party libs * Framework to use mailables * Next iteration of mailables * IDE * Minor UI changes * Laravel's mail templates * Complete refactor of drafting an email. Includes: * Use of Laravel mailables * Markdown support * Markdown preview * Markdown emails now working * [N+] - Patch panel ports - Prewired State - closes #25 * [HK] merge * [HK] merge * [N+] - layer2Interface - add ajax request * [N+] - Need mechanism to insert/update/delete mac addresses from webui / rest / cli #5 * Composer update * fix minor issue layer2address * [N+] - dedup mac addresses in YAML output #10 * [HK] Moving this as it's really a once off task post-upgrade * [REVIEW] Tidy and fix a little logic error in console command * Reformat virtual interface presentation * [REVIEW] Rename view namespace * [REVIEW] Rename views * [REVIEW] Some reactoring and tidy up for presentation of L2 addresses * [REVIEW] Tidy API calls * [REVIEW] Tidy API calls * [REVIEW] Final PR review. Closes islandbridgenetworks/IXP-Manager-Archive-Yann#5 and islandbridgenetworks/IXP-Manager-Archive-Yann#10
Closed
|
Fixed in internal development by commit islandbridgenetworks/IXP-Manager@5beff4e9965220090a442a9e80d21e34866e92a8. This will be available in v4.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Two users have mentioned they have:
"+353 86 876 543 / +353 1 765 4321" in their info for phone/fax info.
Can there be an option to turn this off, or put it underneath the text box instead of in it?
(Also we'd quite like "+44 1234 5678") but this seems to be a library thing?)
The text was updated successfully, but these errors were encountered: