[BF] Issue displaying private VLANs without a physical interface

Thanks to @listerr for working through with me.
inex · Aug 19, 2021 · 9d4d46c · 9d4d46c
1 parent 2fbdee0
commit 9d4d46c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/resources/views/customer/overview-tabs/private-vlans.foil.php b/resources/views/customer/overview-tabs/private-vlans.foil.php
@@ -32,10 +32,11 @@
     <tbody>
         <?php foreach( $pvlans as $vlanid => $pv ): ?>
             <?php foreach( $pv[ "vlis" ] as $vli ):
+
                 /** @var $vli \IXP\Models\VlanInterface */
                 $pis = $vli->virtualInterface->physicalInterfaces;
-                $switcher = $pis[ 0 ]->switchPort->switcher;
-                ?>
+                $switcher = $pis->count() ? $pis[ 0 ]->switchPort->switcher : null;
+            ?>
                 <tr>
                     <td>
                         <?= $t->ee( $vli->vlan->name )?>
@@ -44,7 +45,7 @@
                         <?= $t->ee( $vli->vlan->number )?>
                     </td>
 
-                    <?php if( count( $pis ) > 0 ): ?>
+                    <?php if( $pis->count() ): ?>
                         <td>
                             <?= $t->ee( $switcher->cabinet->location->name ) ?>
                         </td>

diff --git a/resources/views/vlan/private.foil.php b/resources/views/vlan/private.foil.php
@@ -79,12 +79,12 @@ interface details
                             </td>
                             <td>
                                 <?php foreach( $row->vlanInterfaces as $vli ): ?>
-                                    <?= $t->ee( $vli->virtualInterface->physicalInterfaces[ 0 ]->switchPort->switcher->cabinet->location->name ) ?><br />
+                                    <?= !$vli->virtualInterface->physicalInterfaces->count() ?: $t->ee( $vli->virtualInterface->physicalInterfaces[ 0 ]->switchPort->switcher->cabinet->location->name ) ?><br />
                                 <?php endforeach; ?>
                             </td>
                             <td>
                                 <?php foreach( $row->vlanInterfaces as $vli ): ?>
-                                    <?= $t->ee( $vli->virtualInterface->physicalInterfaces[ 0 ]->switchPort->switcher->name ) ?><br />
+                                    <?= !$vli->virtualInterface->physicalInterfaces->count() ?: $t->ee( $vli->virtualInterface->physicalInterfaces[ 0 ]->switchPort->switcher->name ) ?><br />
                                 <?php endforeach; ?>
                             </td>
                         </tr>